Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 9701111: Fix style on network details to put scrollbar in tab contents. (Closed)

Created:
8 years, 9 months ago by flackr
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix style on network details to put scrollbar in tab contents. Make internet details tab contents flexible size and move header of network details out of content-area. BUG=118126 TEST=Open network details, scale down browser until you see a scrollbar. This scrollbar will be within the tab's contents. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127533

Patch Set 1 #

Patch Set 2 : Merge with master. #

Patch Set 3 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/resources/options2/chromeos/internet_detail.css View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_detail.html View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/options2/subpages_tab_controls.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
PTAL, I think we should move the tabstrip styles in network details to apply more ...
8 years, 9 months ago (2012-03-16 19:14:37 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-18 02:44:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9701111/3002
8 years, 9 months ago (2012-03-19 13:39:40 UTC) #3
commit-bot: I haz the power
Try job failure for 9701111-3002 on android for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&number=4270 Step "update" is always ...
8 years, 9 months ago (2012-03-19 13:41:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9701111/9001
8 years, 9 months ago (2012-03-19 17:44:06 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 20:02:29 UTC) #6
Try job failure for 9701111-9001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698