Issue 9701105: Revert 127159 - Refactor extension_function_dispatcher to extract ExtensionFunctionRegistry. This a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701105: Revert 127159 - Refactor extension_function_dispatcher to extract ExtensionFunctionRegistry. This a… (Closed)

Created:
8 years, 9 months ago by miket_OOO

Modified:
8 years, 9 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 127159 - Refactor extension_function_dispatcher to extract ExtensionFunctionRegistry. This allows us to generate an additional code block that takes an ExtensionFunctionRegistry and asks it to register generated API functions. Then switch DnsResolve over to get registered this way. Along the way, notice that DNSResolve is capitalized using an untenable style. Fix that. BUG=none (essential plumbing work) TEST=same as before Review URL: http://codereview.chromium.org/9666059 TBR=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127188

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+595 lines, -796 lines)			Patch
M	build/json_schema_compile.gypi	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/extensions/api/dns/dns_api.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/dns/dns_api.cc	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/api/dns/dns_apitest.cc	View	7 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	4 chunks	+527 lines, -7 lines	0 comments	Download
D	chrome/browser/extensions/extension_function_registry.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	chrome/browser/extensions/extension_function_registry.cc	View	1 chunk	+0 lines, -493 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/json_schema_compiler/compiler.py	View	4 chunks	+23 lines, -72 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_type_generator.py	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_util.py	View	3 chunks	+0 lines, -13 lines	0 comments	Download
D	tools/json_schema_compiler/h_bundle_generator.py	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	tools/json_schema_compiler/h_generator.py	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/json_schema_compiler/test/json_schema_compiler_tests.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages