Issue 9701102: Fix bugs in tools/merge-to-branch.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701102: Fix bugs in tools/merge-to-branch.sh (Closed)

Created:
8 years, 9 months ago by danno

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bugs in tools/merge-to-branch.sh Fail if patches fail to apply and correctly match branches in delete_branch(). R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11073

Patch Set 1 #

Patch Set 2 : Review feedback #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	tools/common-includes.sh	View	1	3 chunks	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-16 16:01:11 UTC) #2

LGTM

http://codereview.chromium.org/9701102/diff/3001/tools/common-includes.sh
File tools/common-includes.sh (right):

http://codereview.chromium.org/9701102/diff/3001/tools/common-includes.sh#new...
tools/common-includes.sh:63: local MATCH=$(git branch | grep "$1" | awk '{print
$NF}' | grep -x $1)
You don't need the quotes around "$1", but I guess they don't matter.

Expand Messages | Collapse Messages