Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 9701102: Fix bugs in tools/merge-to-branch.sh (Closed)

Created:
8 years, 9 months ago by danno
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix bugs in tools/merge-to-branch.sh Fail if patches fail to apply and correctly match branches in delete_branch(). R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11073

Patch Set 1 #

Patch Set 2 : Review feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/common-includes.sh View 1 3 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
danno
PATL
8 years, 9 months ago (2012-03-16 15:54:20 UTC) #1
Jakob Kummerow
8 years, 9 months ago (2012-03-16 16:01:11 UTC) #2
LGTM

http://codereview.chromium.org/9701102/diff/3001/tools/common-includes.sh
File tools/common-includes.sh (right):

http://codereview.chromium.org/9701102/diff/3001/tools/common-includes.sh#new...
tools/common-includes.sh:63: local MATCH=$(git branch | grep "$1" | awk '{print
$NF}' | grep -x $1)
You don't need the quotes around "$1", but I guess they don't matter.

Powered by Google App Engine
This is Rietveld 408576698