Issue 9701093: Adjust heuristics for idle notifications after context disposal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701093: Adjust heuristics for idle notifications after context disposal. (Closed)

Created:
8 years, 9 months ago by ulan

Modified:
8 years, 9 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Adjust heuristics for idle notifications after context disposal. Committed: https://code.google.com/p/v8/source/detail?r=11095

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -55 lines)			Patch
	M	src/heap.h	View		1 chunk	+16 lines, -0 lines	1 comment	Download
	M	src/heap.cc	View		6 chunks	+48 lines, -55 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

Erik, could you please take a look at this? I also uploaded a related patch ...

8 years, 9 months ago (2012-03-16 13:37:23 UTC) #1

Erik Corry

8 years, 9 months ago (2012-03-20 08:15:59 UTC) #2

LGTM

http://codereview.chromium.org/9701093/diff/1/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/9701093/diff/1/src/heap.h#newcode1965
src/heap.h:1965: // - a number less than 1000 for any heap size.
We should either make sure that this is true, or make sure that we do not assume
it.  I would prefer the latter.

Expand Messages | Collapse Messages