Export IPC messages used by mac tests

Export IPC messages used by mac tests

BUG=90078
TEST=none
TBR=jam

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127243

[Nico, 2012-03-16 05:48:26]

I have a question about the best practice for exporting ipc message param
structs below:

https://chromiumcodereview.appspot.com/9701091/diff/1/content/common/gpu/gpu_...
File content/common/gpu/gpu_messages.h (right):

https://chromiumcodereview.appspot.com/9701091/diff/1/content/common/gpu/gpu_...
content/common/gpu/gpu_messages.h:52: #define IPC_MESSAGE_EXPORT CONTENT_EXPORT
This is the only params struct used by tests in the whole file. Is it preferable
to just add the blanket "export everything in this file" define at the top of
the file, or do you prefer exporting just the struct that's actually used?

I think I prefer exporting everything, because limiting visibility doesn't buy
all that much (ideally, many of these structs would be used by tests, which
means they'd have to be exported anyway), but it increases maintenance cost.

https://chromiumcodereview.appspot.com/9701091/diff/1/content/common/text_inp...
File content/common/text_input_client_messages.h (right):

https://chromiumcodereview.appspot.com/9701091/diff/1/content/common/text_inp...
content/common/text_input_client_messages.h:17: #define IPC_MESSAGE_EXPORT
CONTENT_EXPORT
(In this file, the first 4 of 6 messages are used from tests, so exporting just
a few messages doesn't make sense.)

[jam, 2012-03-16 07:03:56]

for style questions about exporting, Dirk or Ricard are much better than me

[rvargas (doing something else), 2012-03-16 18:21:32]

I'm not familiar with the message export etiquette, but in general we try to
export as little as possible... but leaving only a few things not exported when
everything else is exported doesn't look good either.

There is actually some cost in exporting everything: the more exports the slower
the load of that module will be, and there will also be a small increase in
size.

So this change looks fine to me as is.

[rvargas (doing something else), 2012-03-16 18:23:07]

so LGTM :)

[commit-bot: I haz the power, 2012-03-16 18:24:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9701091/2001

[commit-bot: I haz the power, 2012-03-16 18:24:21]

Presubmit check for 9701091-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common/gpu
    content

[Nico, 2012-03-16 18:24:53]

jam: OWNERS

[commit-bot: I haz the power, 2012-03-16 18:25:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9701091/2001

[Dirk Pranke, 2012-03-16 18:31:21]

On 2012/03/16 18:21:32, rvargas wrote:
> I'm not familiar with the message export etiquette, but in general we try to
> export as little as possible... but leaving only a few things not exported
when
> everything else is exported doesn't look good either.
> 
> There is actually some cost in exporting everything: the more exports the
slower
> the load of that module will be, and there will also be a small increase in
> size.
> 
> So this change looks fine to me as is.

I probably would have exported everything for simplicity, but Ricardo is
definitely right that  if you can export fewer things, that's probably better.
It's a lot easier to add exports down the road when you need them than determine
that they're not needed and stop exporting them.

[commit-bot: I haz the power, 2012-03-16 21:31:34]

Change committed as 127243