Issue 9701066: Add bottom margin to overlay page h1 instead of top padding on content-area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701066: Add bottom margin to overlay page h1 instead of top padding on content-area. (Closed)

Created:
8 years, 9 months ago by flackr

Modified:
8 years, 9 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add bottom padding to overlay page h1 instead of top padding on content-area. This makes the scrollbar align where we would expect it to, after the close button's target. BUG=118070 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126980

Patch Set 1 #

Patch Set 2 : Use margin instead of padding to allow margin collapsing with content. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/resources/shared/css/overlay.css	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

flackr

PTAL. Unfortunately the margin isn't collapsed with the first h3 because the content is in ...

8 years, 9 months ago (2012-03-15 17:21:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9701066/2001

8 years, 9 months ago (2012-03-15 17:52:19 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-15 18:42:22 UTC) #4

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for diner.
Ping the relevant dude on a on-needed basis.

Expand Messages | Collapse Messages