Issue 9701064: Experimental profiler: split RegExp.test() for better optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701064: Experimental profiler: split RegExp.test() for better optimization. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Experimental profiler: split RegExp.test() for better optimization. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11065

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fixed bug and added test coverage. #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
	M	src/regexp.js	View	1 2 3	1 chunk	+18 lines, -15 lines	0 comments	Download
	M	test/mjsunit/regexp.js	View	1 2 3	1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2012/03/15 16:25:50, Yang wrote: > PTAL. updated the issue.

8 years, 9 months ago (2012-03-15 16:28:28 UTC) #2

Yang

On 2012/03/15 16:28:28, Yang wrote: > On 2012/03/15 16:25:50, Yang wrote: > > PTAL. > ...

8 years, 9 months ago (2012-03-15 16:46:28 UTC) #3

Jakob Kummerow

8 years, 9 months ago (2012-03-15 17:20:21 UTC) #4

LGTM

http://codereview.chromium.org/9701064/diff/5/test/mjsunit/regexp.js
File test/mjsunit/regexp.js (right):

http://codereview.chromium.org/9701064/diff/5/test/mjsunit/regexp.js#newcode1
test/mjsunit/regexp.js:1: // Copyright 2008 the V8 project authors. All rights
reserved.
2012

Expand Messages | Collapse Messages