Change quoting in Process implementation on Windows.

runtime/bin/process_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ProcessStartStatus {
   int _errorCode;  // Set to OS error code if process start failed.
   String _errorMessage;  // Set to OS error message if process start failed.
 }
 
 
@@ skipping 11 matching lines @@
       throw new ProcessException("Arguments is not a List: $arguments");
     }
     int len = arguments.length;
     _arguments = new ObjectArray<String>(len);
     for (int i = 0; i < len; i++) {
       var arg = arguments[i];
       if (arg is !String) {
         throw new ProcessException("Non-string argument: $arg");
       }
       _arguments[i] = arguments[i];
+      if (new Platform().operatingSystem() == 'windows') {
+        _arguments[i] = _windowsArgumentEscape(_arguments[i]);
+      }
     }
 
     if (workingDirectory is !String && workingDirectory !== null) {
       throw new ProcessException(
           "WorkingDirectory is not a String: $workingDirectory");
     }
     _workingDirectory = workingDirectory;
 
     _in = new _Socket._internalReadOnly();  // stdout coming from process.
     _out = new _Socket._internalWriteOnly();  // stdin going to process.
     _err = new _Socket._internalReadOnly();  // stderr coming from process.
     _exitHandler = new _Socket._internalReadOnly();
     _closed = false;
     _killed = false;
     _started = false;
     _onExit = null;
     // TODO(ager): Make the actual process starting really async instead of
     // simulating it with a timer.
     new Timer(0, (Timer ignore) => start());
   }
 
+  String _windowsArgumentEscape(String argument) {
+    var result = argument;
+    if (argument.contains('\t') || argument.contains(' ')) {
+      // Produce something that the C runtime on Windows will parse
+      // back as this string.
+
+      // Replace any number of '\' followed by '"' with
+      // twice as many '\' followed by '\"'.

[Anton Muhin, 2012/03/15 14:59:39]

I don't know the current status of RegExps, but it looks like a perfect match
for them, something like:

re.replace('(\+)"', '$1$1\"\).

[Mads Ager (google), 2012/03/15 15:32:02]

Yeah, it does. I don't believe that there is support for this syntax though.
Therefore you will have to pick out substrings by hand and the code becomes
almost as big. At that point I don't think the regexp machinery is worth it.

+      StringBuffer sb = new StringBuffer();
+      var nextPos = 0;
+      var quotePos = argument.indexOf('"', nextPos);
+      while (quotePos != -1) {

[Anton Muhin, 2012/03/15 14:59:39]

absolutely up to you,  but I would structure the loop somewhat differently:

while (true) {
  quotePos = ...
  if (quotePos == -1) {
    finish and break;
  }
  ...
}

[Mads Ager (google), 2012/03/15 15:32:02]

I don't really like any of them. I like the explicit break condition the best
though, so leaving as is. Thanks.

+        var numBackslash = 0;
+        var pos = quotePos - 1;
+        while (pos >= 0 && argument.charCodeAt(pos) == '\\'.charCodeAt(0)) {
+          numBackslash++;
+          pos--;
+        }
+        sb.add(argument.substring(nextPos, quotePos - numBackslash));
+        for (var i = 0; i < numBackslash; i++) {
+          sb.add(@'\\');
+        }
+        sb.add(@'\"');
+        nextPos = quotePos + 1;
+        quotePos = argument.indexOf('"', nextPos);
+      }
+      sb.add(argument.substring(nextPos, argument.length));
+      result = sb.toString();
+
+      // Add '"' at the beginning and end and replace all '\' at
+      // the end with two '\'.
+      sb = new StringBuffer('"');
+      sb.add(result);
+      nextPos = argument.length - 1;
+      while (argument.charCodeAt(nextPos) == '\\'.charCodeAt(0)) {
+        sb.add('\\');
+        nextPos--;
+      }
+      sb.add('"');
+      result = sb.toString();
+    }
+
+    return result;
+  }
+
   int _intFromBytes(List<int> bytes, int offset) {
     return (bytes[offset] +
             (bytes[offset + 1] << 8) +
             (bytes[offset + 2] << 16) +
             (bytes[offset + 3] << 24));
   }
 
   void start() {
     var status = new _ProcessStartStatus();
     bool success = _start(_path,
@@ skipping 139 matching lines @@
   Socket _err;
   Socket _exitHandler;
   int _pid;
   bool _closed;
   bool _killed;
   bool _started;
   Function _onExit;
   Function _onError;
   Function _onStart;
 }