Change quoting in Process implementation on Windows.

runtime/bin/process_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <process.h>
 
 #include "bin/builtin.h"
 #include "bin/process.h"
 #include "bin/eventhandler.h"
 #include "bin/thread.h"
@@ skipping 557 matching lines @@
     int error_code = SetOsErrorMessage(os_error_message, os_error_message_len);
     CloseProcessPipes(
         stdin_handles, stdout_handles, stderr_handles, exit_handles);
     return error_code;
   }
 
   // Put together command-line string.
   char* command_line = new char[command_line_length];
   int len = 0;
   int remaining = command_line_length;
-  int written = snprintf(command_line + len, remaining, "\"%s\"", path);
+  // Quote the path if it contains a space.
+  char* format = strchr(path, ' ') != NULL ? "\"%s\"" : "%s";

[Anton Muhin, 2012/03/15 11:52:48]

what if argument is already quoted, do we want to care?

[Mads Ager (google), 2012/03/15 14:32:22]

We don't care that the argument is already quoted. However, if we surround the
argument with quotes, we need to escape any quotes in the string:

a " b -> "a \" b"

That will allow the Windows C library arguments parsing to give 'a " b' as one
argument. Similar care should be taken with \ in an argument that we quote.

+  int written = snprintf(command_line + len, remaining, format, path);
   len += written;
   remaining -= written;
   ASSERT(remaining >= 0);
   for (int i = 0; i < arguments_length; i++) {
-    written = snprintf(command_line + len, remaining, " \"%s\"", arguments[i]);
+    // Quote the argument if it contains a space or a tab.
+    bool contains_tab_or_space = ((strchr(arguments[i], ' ') != NULL) ||
+                                  (strchr(arguments[i], '\t') != NULL));

[Anton Muhin, 2012/03/15 11:52:48]

what about other whitespaces?

[Mads Ager (google), 2012/03/15 14:32:22]

In the command-line that you create the arguments are space or tab separated
only.

+    format = contains_tab_or_space ? " \"%s\"" : " %s";
+    written = snprintf(command_line + len, remaining, format, arguments[i]);
     len += written;
     remaining -= written;
     ASSERT(remaining >= 0);
   }
 
   // Create process.
   BOOL result = CreateProcess(NULL,   // ApplicationName
                               command_line,
                               NULL,   // ProcessAttributes
                               NULL,   // ThreadAttributes
@@ skipping 49 matching lines @@
   if (!result) {
     return false;
   }
   return true;
 }
 
 
 void Process::TerminateExitCodeHandler() {
   ExitCodeHandler::TerminateExitCodeThread();
 }