Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 9701056: Revert 126809 - bluetooth: remove command-line flag, enabling by default (Closed)

Created:
8 years, 9 months ago by scottmg
Modified:
8 years, 9 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 126809 - bluetooth: remove command-line flag, enabling by default Bluetooth is to be enabled by default for R19, the UI already includes a separate "Enable bluetooth" checkbox that is connected to the radio power, so there is no need to leave the flag in place. BUG=chromium-os:23022, chromium:106446 TEST=verified bluetooth now enabled by default Change-Id: I0814b903d4764774cb63fb0b2c003ee0d5c9a49e Review URL: http://codereview.chromium.org/9702028 TBR=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 9 months ago (2012-03-15 02:48:00 UTC) #1
scottmg
On 2012/03/15 02:48:00, scottmg wrote: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tester%20%282%29&number=778 base::debug::StackTrace::StackTrace() [0x14db9ce] base::(anonymous namespace)::StackDumpSignalHandler() [0x1515fc9] 0x7f778f886af0 chromeos::BluetoothAdapter::RemoveObserver() [0x1238fe1] chromeos::BluetoothOptionsHandler::~BluetoothOptionsHandler() ...
8 years, 9 months ago (2012-03-15 02:50:01 UTC) #2
keybuk
8 years, 9 months ago (2012-03-15 17:15:47 UTC) #3
Thanks - looks like a change to the webui code broke it

On Wed, Mar 14, 2012 at 7:50 PM, <scottmg@chromium.org> wrote:

> On 2012/03/15 02:48:00, scottmg wrote:
>
> http://build.chromium.org/p/**chromium.chromiumos/**
>
buildstatus?builder=Linux%**20ChromiumOS%20Tester%20%282%**29&number=778<http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tester%20%282%29&number=778>
>
> base::debug::StackTrace::**StackTrace() [0x14db9ce]
>        base::(anonymous namespace)::**StackDumpSignalHandler() [0x1515fc9]
>        0x7f778f886af0
>        chromeos::BluetoothAdapter::**RemoveObserver() [0x1238fe1]
>        chromeos::**BluetoothOptionsHandler::~**BluetoothOptionsHandler()
> [0x1192bf1]
>        WebUIImpl::~WebUIImpl() [0x2eee85f]
>        RenderViewHostManager::~**RenderViewHostManager() [0x2edb92a]
>        TabContents::~TabContents() [0x2ee3af3]
>        TabContentsWrapper::~**TabContentsWrapper() [0xd3d99e]
>        TabStripModel::**InternalCloseTab() [0xce2dd3]
>        TabStripModel::**InternalCloseTabs() [0xce574e]
>        TabStripModel::CloseAllTabs() [0xce58c3]
>        Browser::OnWindowClosing() [0xd0f815]
>        Browser::ProcessPendingTabs() [0xd0f503]
>        Browser::ClearUnloadState() [0xd0f4c8]
>        Browser::CloseContents() [0xd0fc9a]
>        IPC::Message::Dispatch<>() [0x2e8f414]
>        content::RenderViewHostImpl::**OnMessageReceived() [0x2e98dc3]
>        RenderProcessHostImpl::**OnMessageReceived() [0x2e897ad]
>        IPC::ChannelProxy::Context::**OnDispatchMessage() [0x1bed8be]
>        MessageLoop::RunTask() [0x14fdb5e]
>        MessageLoop::**DeferOrRunPendingTask() [0x14fe288]
>        MessageLoop::DoWork() [0x14fe888]
>
>
https://chromiumcodereview.**appspot.com/9701056/<https://chromiumcodereview....
>

Powered by Google App Engine
This is Rietveld 408576698