Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: build/common.gypi

Issue 9701050: Make setup.exe compatible with the component build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment nits Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 3f3d972a95db4010ae5156241c1af24a3acdf6c3..27aa34111db957ce3a711f11098c6f221656d615 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2832,6 +2832,23 @@
'_HAS_EXCEPTIONS=0',
],
}],
+ # To support installing a component build (where the DLLs are not in
+ # same directory as chrome.exe and setup.exe):
rvargas (doing something else) 2012/05/16 01:09:58 What does this exactly mean? I don't think this is
gab 2012/05/16 01:15:54 It will, but not this way. Follow https://chromium
+ # create_installer_archive.py writes custom manifests for all the
+ # DLLs. The setting below prevents VS from automatically generating
+ # the usual manifests for those DLLs which would override the custom
+ # external manifests.
+ ['component=="shared_library"', {
+ 'target_conditions': [
+ ['_type=="shared_library"', {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'GenerateManifest': 'false',
+ },
+ },
+ }],
+ ],
+ }],
['MSVS_VERSION=="2008"', {
'defines': [
'_HAS_TR1=0',
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698