Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h

Issue 9701040: Revert 126715 - Update the tcmalloc vendor branch to r144 (gperftools 2.0). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h
===================================================================
--- third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h (revision 126727)
+++ third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h (working copy)
@@ -40,21 +40,15 @@
#include <sys/mman.h>
#include <errno.h>
+static inline void* do_mmap(void *start, size_t length,
+ int prot, int flags,
+ int fd, off_t offset) __THROW {
+ return (void *)syscall(SYS_mmap, start, length, prot, flags, fd, offset);
+}
+
// Make sure mmap doesn't get #define'd away by <sys/mman.h>
#undef mmap
-// According to the FreeBSD documentation, use syscall if you do not
-// need 64-bit alignment otherwise use __syscall. Indeed, syscall
-// doesn't work correctly in most situations on 64-bit. It's return
-// type is 'int' so for things like SYS_mmap, it actually truncates
-// the returned address to 32-bits.
-#if defined(__amd64__) || defined(__x86_64__)
-# define MALLOC_HOOK_SYSCALL __syscall
-#else
-# define MALLOC_HOOK_SYSCALL syscall
-#endif
-
-
extern "C" {
void* mmap(void *start, size_t length,int prot, int flags,
int fd, off_t offset) __THROW
@@ -65,47 +59,20 @@
ATTRIBUTE_SECTION(malloc_hook);
}
-static inline void* do_mmap(void *start, size_t length,
- int prot, int flags,
- int fd, off_t offset) __THROW {
- return (void *)MALLOC_HOOK_SYSCALL(SYS_mmap,
- start, length, prot, flags, fd, offset);
-}
-
static inline void* do_sbrk(intptr_t increment) {
- void* curbrk = 0;
+ void* curbrk;
-#if defined(__x86_64__) || defined(__amd64__)
-# ifdef PIC
__asm__ __volatile__(
- "movq .curbrk@GOTPCREL(%%rip), %%rdx;"
- "movq (%%rdx), %%rax;"
- "movq %%rax, %0;"
- : "=r" (curbrk)
- :: "%rdx", "%rax");
-# else
- __asm__ __volatile__(
- "movq .curbrk(%%rip), %%rax;"
- "movq %%rax, %0;"
- : "=r" (curbrk)
- :: "%rax");
-# endif
-#else
- __asm__ __volatile__(
"movl .curbrk, %%eax;"
- "movl %%eax, %0;"
+ "movl %%eax, %0"
: "=r" (curbrk)
:: "%eax");
-#endif
- if (increment == 0) {
- return curbrk;
- }
-
char* prevbrk = static_cast<char*>(curbrk);
void* newbrk = prevbrk + increment;
if (brk(newbrk) == -1) {
+ assert(0);
return reinterpret_cast<void*>(static_cast<intptr_t>(-1));
}
@@ -116,24 +83,15 @@
extern "C" void* mmap(void *start, size_t length, int prot, int flags,
int fd, off_t offset) __THROW {
MallocHook::InvokePreMmapHook(start, length, prot, flags, fd, offset);
- void *result;
- if (!MallocHook::InvokeMmapReplacement(
- start, length, prot, flags, fd, offset, &result)) {
- result = do_mmap(start, length, prot, flags, fd,
- static_cast<size_t>(offset)); // avoid sign extension
- }
+ void *result = do_mmap(start, length, prot, flags, fd,
+ static_cast<size_t>(offset)); // avoid sign extension
MallocHook::InvokeMmapHook(result, start, length, prot, flags, fd, offset);
return result;
}
extern "C" int munmap(void* start, size_t length) __THROW {
MallocHook::InvokeMunmapHook(start, length);
- int result;
- if (!MallocHook::InvokeMunmapReplacement(start, length, &result)) {
- result = MALLOC_HOOK_SYSCALL(SYS_munmap, start, length);
- }
-
- return result;
+ return syscall(SYS_munmap, start, length);
}
extern "C" void* sbrk(intptr_t increment) __THROW {
@@ -145,21 +103,9 @@
/*static*/void* MallocHook::UnhookedMMap(void *start, size_t length, int prot,
int flags, int fd, off_t offset) {
- void* result;
- if (!MallocHook::InvokeMmapReplacement(
- start, length, prot, flags, fd, offset, &result)) {
- result = do_mmap(start, length, prot, flags, fd, offset);
- }
-
- return result;
+ return mmap(start, length, prot, flags, fd, offset);
}
/*static*/int MallocHook::UnhookedMUnmap(void *start, size_t length) {
- int result;
- if (!MallocHook::InvokeMunmapReplacement(start, length, &result)) {
- result = MALLOC_HOOK_SYSCALL(SYS_munmap, start, length);
- }
- return result;
+ return munmap(start, length);
}
-
-#undef MALLOC_HOOK_SYSCALL
« no previous file with comments | « third_party/tcmalloc/vendor/src/malloc_hook-inl.h ('k') | third_party/tcmalloc/vendor/src/malloc_hook_mmap_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698