Fix pincode versus passkey issues for Bluetooth pairing.

Fix pincode versus passkey issues for Bluetooth pairing.

BUG=chromium-os:27699, chromium-os:27754
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126938

[kevers, 2012-03-15 15:39:09]

Hi James,

Can you take a look at this CL, which enforces constraints on Bluetooth passkeys
and pincodes.

[keybuk, 2012-03-15 16:06:45]

I don't like the filtered code here, we want the box to only accept numbers, not
ignore anything entered that's not a number - either entering text should give
an error and not send the Passkey back, or it shouldn't be possible to enter
non-numerics at all

Isn't there a way to do this with a javascript callback for each character if
type="number" isn't sufficient?

[kevers, 2012-03-15 16:27:30]

<input type="number"> has a whole host of problems with it, some of which were
noted in the comment above the regex replace call.  Number does not limit the
length (even with min and max set), allows negatives, resulted in bad painting
artifacts, allowed negatives.  In short, even if we used type="number" we would
still need to apply regex filtering and address the painting artifacts.

[kevers, 2012-03-15 16:29:45]

Should have added in my previous not that the oninput callback that contains the
filtering will fire after each keystroke.  The user will not see "12ab3" ->
"123" or any weird nonsense like that.

[keybuk, 2012-03-15 17:18:42]

Ah, I assumed this was just on submission

[keybuk, 2012-03-15 17:18:47]

lgtm

[James Hawkins, 2012-03-15 17:25:29]

LGTM with nit.

http://codereview.chromium.org/9701012/diff/2003/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/bluetooth.css (right):

http://codereview.chromium.org/9701012/diff/2003/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/bluetooth.css:76: 
nit: Remove extra blank line.

[kevers, 2012-03-15 17:36:19]

http://codereview.chromium.org/9701012/diff/2003/chrome/browser/resources/opt...
File chrome/browser/resources/options2/chromeos/bluetooth.css (right):

http://codereview.chromium.org/9701012/diff/2003/chrome/browser/resources/opt...
chrome/browser/resources/options2/chromeos/bluetooth.css:76: 
On 2012/03/15 17:25:30, James Hawkins wrote:
> nit: Remove extra blank line.

Done.