Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 9700088: Check for specific PPB interface versions in C++ wrappers. (Closed)

Created:
8 years, 9 months ago by Wez
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Check for specific PPB interface versions in the C++ wrappers for Graphics2D, *InputEvent, Instance, ImageData, Module, Rect, URLLoader, URLRequestInfo and URLResponseInfo. BUG=107398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128125

Patch Set 1 #

Patch Set 2 : Update Module, Rect, URLLoader, URLRequestInfo and URLResponseInfo. #

Patch Set 3 : Fix copyright years, since we'll have to bypass hooks for the TODO to stay. #

Patch Set 4 : Fix MouseInputEvent version check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -141 lines) Patch
M ppapi/cpp/graphics_2d.cc View 1 2 6 chunks +15 lines, -15 lines 0 comments Download
M ppapi/cpp/image_data.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M ppapi/cpp/input_event.cc View 1 2 3 10 chunks +47 lines, -47 lines 0 comments Download
M ppapi/cpp/instance.cc View 1 2 3 chunks +23 lines, -22 lines 0 comments Download
M ppapi/cpp/module.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/rect.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/url_loader.cc View 1 2 4 chunks +21 lines, -21 lines 0 comments Download
M ppapi/cpp/url_request_info.cc View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M ppapi/cpp/url_response_info.cc View 1 2 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Wez
Mostly a search-and-replace CL to check for specific interface versions in the C++ wrappers.
8 years, 9 months ago (2012-03-16 05:41:28 UTC) #1
brettw
LGTM
8 years, 9 months ago (2012-03-16 06:06:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9700088/1001
8 years, 9 months ago (2012-03-16 06:11:25 UTC) #3
commit-bot: I haz the power
Presubmit check for 9700088-1001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-16 06:11:31 UTC) #4
Wez
8 years, 9 months ago (2012-03-16 06:20:39 UTC) #5
On 2012/03/16 06:11:31, I haz the power (commit-bot) wrote:
> Presubmit check for 9700088-1001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> TODOs found in stable public PPAPI files:
> 
> ***************
> ppapi/cpp/instance.cc
> ***************
> 
> Presubmit checks took 1.2s to calculate.

Brett, there's a TODO to check which thread we're on in pp::Instance; do you
want it leaving there?

Powered by Google App Engine
This is Rietveld 408576698