Fix for issue 2124 - Dart VM crashes on windows

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 8308 matching lines @@
   // that it can be traversed over successfully during garbage collection.
   if (capacity_size != used_size) {
     NoGCScope no_gc;
     ASSERT(capacity_len > used_len);
     intptr_t leftover_size = capacity_size - used_size;
 
     uword addr = RawObject::ToAddr(array.raw()) + used_size;
     if (leftover_size >= Array::InstanceSize(0)) {
       // As we have enough space to use an array object, update the leftover
       // space as an Array object.
-      new_array.raw_ = reinterpret_cast<RawArray*>(RawObject::FromAddr(addr));
-      new_array.raw_ptr()->class_ = isolate->object_store()->array_class();
+      RawArray* raw = reinterpret_cast<RawArray*>(RawObject::FromAddr(addr));
+      raw->ptr()->class_ = isolate->object_store()->array_class();
       tags = RawObject::SizeTag::update(leftover_size, tags);
-      new_array.raw_ptr()->tags_ = tags;
+      raw->ptr()->tags_ = tags;
       intptr_t leftover_len =
           ((leftover_size - Array::InstanceSize(0)) / kWordSize);
-      new_array.SetLength(leftover_len);
+      raw->ptr()->tags_ = tags;
+      raw->ptr()->length_ = Smi::New(leftover_len);
     } else {
       // Update the leftover space as a basic object.
       ASSERT(leftover_size == Object::InstanceSize());
-      Object& new_object = Object::Handle(isolate, RawObject::FromAddr(addr));
-      new_object.raw()->ptr()->class_ = isolate->object_store()->object_class();
+      RawObject* raw = reinterpret_cast<RawObject*>(RawObject::FromAddr(addr));
+      raw->ptr()->class_ = isolate->object_store()->object_class();
       tags = RawObject::SizeTag::update(leftover_size, tags);
-      new_object.raw()->ptr()->tags_ = tags;
+      raw->ptr()->tags_ = tags;
     }
   }
   return array.raw();
 }
 
 
 RawImmutableArray* ImmutableArray::New(intptr_t len,
                                        Heap::Space space) {
   ObjectStore* object_store = Isolate::Current()->object_store();
   Class& cls = Class::Handle(object_store->immutable_array_class());
@@ skipping 549 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart