src/full-codegen.cc - Issue 9700062: Mark Code objects as not optimizable if their FunctionLiteral contains unoptimizable AST nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 9700062: Mark Code objects as not optimizable if their FunctionLiteral contains unoptimizable AST nodes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index f77c82df5129019d1f686a6c6e1ccf23491dc882..d963979ad867f0a8bc2d6c649af00383bed442da 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -313,7 +313,8 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {

Code::Flags flags = Code::ComputeFlags(Code::FUNCTION);

Handle<Code> code = CodeGenerator::MakeCodeEpilogue(&masm, flags, info);

- code->set_optimizable(info->IsOptimizable());

+ code->set_optimizable(info->IsOptimizable() &&

+ !info->function()->flags()->Contains(kDontOptimize));

code->set_self_optimization_header(cgen.has_self_optimization_header_);

cgen.PopulateDeoptimizationData(code);

cgen.PopulateTypeFeedbackInfo(code);

« no previous file with comments | « src/ast.cc ('k') | src/objects.cc » ('j') | no next file with comments »