Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/objects.cc

Issue 9700062: Mark Code objects as not optimizable if their FunctionLiteral contains unoptimizable AST nodes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/full-codegen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7362 matching lines...) Expand 10 before | Expand all | Expand 10 after
7373 IteratePointers(v, kPropertiesOffset, kCodeEntryOffset); 7373 IteratePointers(v, kPropertiesOffset, kCodeEntryOffset);
7374 v->VisitCodeEntry(this->address() + kCodeEntryOffset); 7374 v->VisitCodeEntry(this->address() + kCodeEntryOffset);
7375 IteratePointers(v, kCodeEntryOffset + kPointerSize, object_size); 7375 IteratePointers(v, kCodeEntryOffset + kPointerSize, object_size);
7376 } 7376 }
7377 7377
7378 7378
7379 void JSFunction::MarkForLazyRecompilation() { 7379 void JSFunction::MarkForLazyRecompilation() {
7380 ASSERT(is_compiled() && !IsOptimized()); 7380 ASSERT(is_compiled() && !IsOptimized());
7381 ASSERT(shared()->allows_lazy_compilation() || 7381 ASSERT(shared()->allows_lazy_compilation() ||
7382 code()->optimizable()); 7382 code()->optimizable());
7383 ASSERT(!shared()->optimization_disabled());
7383 Builtins* builtins = GetIsolate()->builtins(); 7384 Builtins* builtins = GetIsolate()->builtins();
7384 ReplaceCode(builtins->builtin(Builtins::kLazyRecompile)); 7385 ReplaceCode(builtins->builtin(Builtins::kLazyRecompile));
7385 } 7386 }
7386 7387
7387 7388
7388 bool SharedFunctionInfo::EnsureCompiled(Handle<SharedFunctionInfo> shared, 7389 bool SharedFunctionInfo::EnsureCompiled(Handle<SharedFunctionInfo> shared,
7389 ClearExceptionFlag flag) { 7390 ClearExceptionFlag flag) {
7390 return shared->is_compiled() || CompileLazy(shared, flag); 7391 return shared->is_compiled() || CompileLazy(shared, flag);
7391 } 7392 }
7392 7393
(...skipping 5563 matching lines...) Expand 10 before | Expand all | Expand 10 after
12956 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 12957 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
12957 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 12958 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
12958 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 12959 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
12959 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 12960 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
12960 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 12961 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
12961 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 12962 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
12962 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 12963 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
12963 } 12964 }
12964 12965
12965 } } // namespace v8::internal 12966 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698