Issue 9700061: Record the addresses of pages that are unmapped to aid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9700061: Record the addresses of pages that are unmapped to aid (Closed)

Created:
8 years, 9 months ago by Erik Corry

Modified:
8 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Record the addresses of pages that are unmapped to aid in post mortem crash dump analysis. Committed: https://code.google.com/p/v8/source/detail?r=11071

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
M	src/heap.h	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm http://codereview.chromium.org/9700061/diff/3002/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9700061/diff/3002/src/spaces.cc#newcode598 src/spaces.cc:598: reinterpret_cast<Address>(chunk), chunk->IsEvacuationCandidate()); I think we clear evacuation candidate ...

8 years, 9 months ago (2012-03-16 11:56:52 UTC) #1

still lgtm

Expand Messages | Collapse Messages

Issue 9700061: Record the addresses of pages that are unmapped to aid (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages