Issue 9700057: Fix a typo and a style nit in some of TSan suppressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9700057: Fix a typo and a style nit in some of TSan suppressions (Closed)

Created:
8 years, 9 months ago by Timur Iskhodzhanov

Modified:
8 years, 9 months ago

Reviewers:
Brad Chen (chromium), Brad Chen

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix a typo and a style nit in some of TSan suppressions BUG=113771 TBR=bradchen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126902

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	tools/valgrind/tsan/suppressions.txt	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brad Chen

8 years, 9 months ago (2012-03-15 14:13:14 UTC) #2

LGTM

On Thu, Mar 15, 2012 at 6:32 AM, <timurrrr@chromium.org> wrote:

> Reviewers: Brad Chen (chromium),
>
> Description:
> Fix a typo and a style nit in some of TSan suppressions
> BUG=113771
> TBR=bradchen
>
> Please review this at
https://chromiumcodereview.**appspot.com/9700057/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/valgrind/tsan/**suppressions.txt
>
>
> Index: tools/valgrind/tsan/**suppressions.txt
> ==============================**==============================**=======
> --- tools/valgrind/tsan/**suppressions.txt        (revision 126886)
> +++ tools/valgrind/tsan/**suppressions.txt        (working copy)
> @@ -810,16 +810,15 @@
>   fun:base::internal::**RunnableAdapter::Run
>  }
>  {
> -  bug_131771
> +  bug_113771_a
>   ThreadSanitizer:Race
>   fun:tracked_objects::**ThreadData::TrackingStatus
>   fun:tracked_objects::**ThreadData::**TallyABirthIfActive
>   fun:base::TrackingInfo::**TrackingInfo
>   fun:base::PendingTask::**PendingTask
> -  ...
>  }
>  {
> -  bug_131771_a
> +  bug_113771_b
>   ThreadSanitizer:Race
>   fun:tracked_objects::**ThreadData::TrackingStatus
>   fun:tracked_objects::**ThreadData::Now
> @@ -827,7 +826,7 @@
>   fun:MessageLoop::RunTask
>  }
>  {
> -  bug_131771_b
> +  bug_113771_c
>   ThreadSanitizer:Race
>   fun:tracked_objects::**ThreadData::TrackingStatus
>   fun:tracked_objects::**ThreadData::Now
>
>
>

Expand Messages | Collapse Messages