Issue 9700036: ash: Add image files for the network dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9700036: ash: Add image files for the network dialog. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Add image files for the network dialog. BUG=110130, 109480 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126726

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A	ui/resources/aura/status_less.png	View	+-1 lines, --1 lines	0 comments	Download
A	ui/resources/aura/status_more.png	View	+-1 lines, --1 lines	0 comments	Download
A	ui/resources/aura/status_network_airplane.png	View	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

Image files for http://codereview.chromium.org/9704029/ so I can run it through the trybots this time.

8 years, 9 months ago (2012-03-14 20:11:29 UTC) #1

Ben Goodger (Google)

8 years, 9 months ago (2012-03-14 20:29:31 UTC) #2

LGTM

On Wed, Mar 14, 2012 at 1:11 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Image files for
http://codereview.chromium.**org/9704029/<http://codereview.chromium.org/9704...
I can run it through
> the trybots this time.
>
> Description:
> ash: Add image files for the network dialog.
>
> BUG=110130, 109480
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/9700036/<http://codereview.chromium.org/9700...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  A ui/resources/aura/status_less.**png
>  A ui/resources/aura/status_more.**png
>  A ui/resources/aura/status_**network_airplane.png
>
>
> Index: ui/resources/aura/status_less.**png
> diff --git a/ui/resources/aura/status_**less.png
> b/ui/resources/aura/status_**less.png
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> 9c9cdfed899d7d01da1ce50aad9049**2ce17b345c
> Binary files /dev/null and b/ui/resources/aura/status_**less.png differ
> Index: ui/resources/aura/status_more.**png
> diff --git a/ui/resources/aura/status_**more.png
> b/ui/resources/aura/status_**more.png
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> c28eae3d336860bdd9316836f95a96**072b0104c6
> Binary files /dev/null and b/ui/resources/aura/status_**more.png differ
> Index: ui/resources/aura/status_**network_airplane.png
> diff --git a/ui/resources/aura/status_**network_airplane.png
> b/ui/resources/aura/status_**network_airplane.png
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> 7a1e561dfc6ad329fe26bc6dfd744b**f1cebaf025
> Binary files /dev/null and b/ui/resources/aura/status_**network_airplane.png
> differ
>
>
>

Expand Messages | Collapse Messages