Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9700018: Revert "Wrap multioption args into quotes." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 dumpRenderTreeFilename, 560 dumpRenderTreeFilename,
561 '--no-timeout' 561 '--no-timeout'
562 ]; 562 ];
563 if (component == 'dartium') { 563 if (component == 'dartium') {
564 var dartFlags = ['--ignore-unrecognized-flags']; 564 var dartFlags = ['--ignore-unrecognized-flags'];
565 if (configuration["checked"]) { 565 if (configuration["checked"]) {
566 dartFlags.add('--enable_asserts'); 566 dartFlags.add('--enable_asserts');
567 dartFlags.add("--enable_type_checks"); 567 dartFlags.add("--enable_type_checks");
568 } 568 }
569 dartFlags.addAll(vmOptions); 569 dartFlags.addAll(vmOptions);
570 final joined = Strings.join(dartFlags, ' '); 570 args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
571 args.add('--dart-flags="$joined"');
572 } 571 }
573 args.add(htmlPath); 572 args.add(htmlPath);
574 } 573 }
575 commands.add(new Command('python', args)); 574 commands.add(new Command('python', args));
576 575
577 // Create BrowserTestCase and queue it. 576 // Create BrowserTestCase and queue it.
578 var testCase = new BrowserTestCase(testName, commands, configuration, 577 var testCase = new BrowserTestCase(testName, commands, configuration,
579 completeHandler, expectations, optionsFromFile['isNegative']); 578 completeHandler, expectations, optionsFromFile['isNegative']);
580 doTest(testCase); 579 doTest(testCase);
581 } 580 }
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1226 * $noCrash tests are expected to be flaky but not crash 1225 * $noCrash tests are expected to be flaky but not crash
1227 * $pass tests are expected to pass 1226 * $pass tests are expected to pass
1228 * $failOk tests are expected to fail that we won't fix 1227 * $failOk tests are expected to fail that we won't fix
1229 * $fail tests are expected to fail that we should fix 1228 * $fail tests are expected to fail that we should fix
1230 * $crash tests are expected to crash that we should fix 1229 * $crash tests are expected to crash that we should fix
1231 * $timeout tests are allowed to timeout 1230 * $timeout tests are allowed to timeout
1232 """; 1231 """;
1233 print(report); 1232 print(report);
1234 } 1233 }
1235 } 1234 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698