Move params/callbacks to gdata_params.

Move params/callbacks to gdata_params.

Reduce the size of gdata.h and remove gdata.h from gdata_files.h and gdata_file_system.h

BUG=NONE
TEST=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126766

[achuithb, 2012-03-14 10:20:04]

Not urgent, but please take a look when you get a chance.

[satorux1, 2012-03-14 17:08:04]

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_params.cc (right):

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_params.cc:9:
//============================== ResumeUploadResponse ==========================
nit: the file is small, so we probably don't need separators like this.

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_params.h (right):

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_params.h:76: typedef
base::Callback<void(GDataErrorCode error,
While you are at it, can you add some comment about what the callback is used
for? Please do the same for other callback types.

Since the callback types are defined in a separate file, documentation would be
more helpful.

[achuithb, 2012-03-14 20:22:58]

Addressed both comments. PTAL, Satoru-san.

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_params.cc (right):

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_params.cc:9:
//============================== ResumeUploadResponse ==========================
On 2012/03/14 17:08:04, satorux1 wrote:
> nit: the file is small, so we probably don't need separators like this.

Done.

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_params.h (right):

http://codereview.chromium.org/9700014/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_params.h:76: typedef
base::Callback<void(GDataErrorCode error,
On 2012/03/14 17:08:04, satorux1 wrote:
> While you are at it, can you add some comment about what the callback is used
> for? Please do the same for other callback types.
> 
> Since the callback types are defined in a separate file, documentation would
be
> more helpful.
> 

Done.

[satorux1, 2012-03-14 20:28:16]

LGTM.

We might also want to split gdata.h to something like

gdata_auth_service.h
gdata_documents_service.h

but let's do this in a separate patch, if we are to do this.

[achuithb, 2012-03-14 20:28:54]

On 2012/03/14 20:28:16, satorux1 wrote:
> LGTM.
> 
> We might also want to split gdata.h to something like
> 
> gdata_auth_service.h
> gdata_documents_service.h
> 
> but let's do this in a separate patch, if we are to do this.

Agreed.