Close connections on server.close(), and call onError on early connection close.

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _HttpRequestResponseBase {
   _HttpRequestResponseBase(_HttpConnectionBase this._httpConnection)
       : _contentLength = -1,
         _keepAlive = false,
         _headers = new Map();
 
@@ skipping 608 matching lines @@
         if (_onError != null) _onError(errorMessage);
       }
       connection.onError = onError;
     }
 
     _connections = new Set<_HttpConnection>();
     _server = new ServerSocket(host, port, backlog);
     _server.onConnection = onConnection;
   }
 
-  void close() => _server.close();
+  void close() {
+    _server.close();
+    for (_HttpConnection connection in _connections) {
+      connection._socket.close();
+    }
+  }
+
   int get port() => _server.port;
 
   void set onError(void handler(String errorMessage)) {
     _onError = handler;
   }
 
   void set onRequest(void handler(HttpRequest, HttpResponse)) {
     _onRequest = handler;
   }
 
@@ skipping 240 matching lines @@
     _httpParser.requestStart =
         (method, uri) => _onRequestStart(method, uri);
     _httpParser.responseStart =
         (statusCode, reasonPhrase) =>
             _onResponseStart(statusCode, reasonPhrase);
     _httpParser.headerReceived =
         (name, value) => _onHeaderReceived(name, value);
     _httpParser.headersComplete = () => _onHeadersComplete();
     _httpParser.dataReceived = (data) => _onDataReceived(data);
     _httpParser.dataEnd = () => _onDataEnd();
+    onDisconnect = _onDisconnected;
   }
 
   HttpClientRequest open(String method, String uri) {
     _request = new _HttpClientRequest(method, uri, this);
     _request.keepAlive = true;
     _response = new _HttpClientResponse(this);
     return _request;
   }
 
   void _onRequestStart(String method, String uri) {
@@ skipping 10 matching lines @@
 
   void _onHeadersComplete() {
     _response._onHeadersComplete();
   }
 
   void _onDataReceived(List<int> data) {
     _response._onDataReceived(data);
   }
 
   void _onDataEnd() {
+    onDisconnect = null;
     if (_response.headers["connection"] == "close") {
       _socket.close();
     } else {
       _client._returnSocketConnection(_socketConn);
       _socket = null;
       _socketConn = null;
     }
     _response._onDataEnd();
   }
 
   void set onRequest(void handler(HttpClientRequest request)) {
     _onRequest = handler;
   }
 
   void set onResponse(void handler(HttpClientResponse response)) {
     _onResponse = handler;
   }
 
+  void _onDisconnected() {

[Søren Gjesse, 2012/03/14 09:26:59]

We probably need to handle this slightly differently. If the response has either
a Content-Length or chuncked encoding then this should be fine. However in the
case where neither Content-Length nor chunked transfer is specified then closing
the connection is the correct way of indicating the end of the response (see RFC
2616 section "4.4 Message Length").

To actually test this with the Dart HTTP server we need to add some way of
sending a response without Content-Length and also not use chunked encoding.

[Anders Johnsen, 2012/03/14 09:34:43]

My initial understanding was that _onDataEnd was called iff all content have
been received, independent of how the data-end was marked. How can we go about
adding such an event?

[Søren Gjesse, 2012/03/14 10:03:30]

You are right this should be fixed in the HTTP parser. The HTTP parser should
have an additional method connectionClosed. Here The HTTP parser needs to handle
closing sockets correctly. It should emit a dataEnd event if we are in the case
where neither Content_Length nor chunked encoding is specified, and receiving
close is fine and otherwise emmit an onError event (currently missing)
indicating premature disconnect.

[Anders Johnsen, 2012/03/14 10:08:54]

Want me to make it a part of this cl, or is it something we want to visit
later(adding TODO)?

+    if (_onErrorCallback !== null) {
+      _onErrorCallback(
+          new HttpException("Client disconnected before response was sent."));

[Søren Gjesse, 2012/03/14 09:26:59]

"was sent" should probably be "was received".

[Anders Johnsen, 2012/03/14 09:34:43]

Done.

+    }
+  }
+
+
   Function _onRequest;
   Function _onResponse;
 
   _HttpClient _client;
   _SocketConnection _socketConn;
   HttpClientRequest _request;
   HttpClientResponse _response;
 
   // Callbacks.
   var requestReceived;
@@ skipping 190 matching lines @@
     _onError = callback;
   }
 
   Function _onOpen;
   Function _onError;
   Map<String, Queue<_SocketConnection>> _openSockets;
   Set<_SocketConnection> _activeSockets;
   Timer _evictionTimer;
   bool _shutdown;  // Has this HTTP client been shutdown?
 }