chrome/browser/chromeos/extensions/file_browser_private_api.cc - Issue 9700011: Convert file url to lowercase to make it match a file handler pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_browser_private_api.cc

Issue 9700011: Convert file url to lowercase to make it match a file handler pattern. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More careful UTF8 handling Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc

index 8222f6bc3775fe5ee5b396568c702a708f74cae8..3401a107048964ab2a7ec3483d7d95019c3ba17e 100644

--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc

+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc

@@ -547,10 +547,6 @@ bool GetFileTasksFileBrowserFunction::RunImpl() {

std::string file_url;

if (!files_list->GetString(i, &file_url))

return false;

- // We need case-insensitive matching, and pattern in handler is already

- // in lower case.

- StringToLowerASCII(&file_url);

file_urls.push_back(GURL(file_url));

}