chrome/browser/chromeos/extensions/file_handler_util.cc - Issue 9700011: Convert file url to lowercase to make it match a file handler pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_handler_util.cc

Issue 9700011: Convert file url to lowercase to make it match a file handler pattern. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/file_handler_util.cc

diff --git a/chrome/browser/chromeos/extensions/file_handler_util.cc b/chrome/browser/chromeos/extensions/file_handler_util.cc

index 743f8c548cd5edbbddf5719ee1d67013a78625fb..eceab137117e76c4af104311b836097857a84b46 100644

--- a/chrome/browser/chromeos/extensions/file_handler_util.cc

+++ b/chrome/browser/chromeos/extensions/file_handler_util.cc

@@ -227,7 +227,9 @@ bool FindCommonTasks(Profile* profile,

bool GetDefaultTask(

Profile* profile, const GURL& url, const FileBrowserHandler** handler) {

std::vector<GURL> file_urls;

- file_urls.push_back(url);

+ std::string url_spec = url.spec();

+ StringToLowerASCII(&url_spec);

SeRya 2012/03/14 09:08:55 How about non-ASCII patterns? A third party app ma

Vladislav Kaznacheev 2012/03/14 11:08:20 Done.

+ file_urls.push_back(GURL(url_spec));

LastUsedHandlerList common_tasks;

if (!FindCommonTasks(profile, file_urls, &common_tasks))

« no previous file with comments | « no previous file | no next file » | no next file with comments »