Convert file url to lowercase to make it match a file handler pattern.

chrome/browser/chromeos/extensions/file_handler_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_handler_util.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
+#include "base/i18n/case_conversion.h"
 #include "base/json/json_writer.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/extensions/file_browser_handler.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
+#include "net/base/escape.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_mount_point_provider.h"
 #include "webkit/fileapi/file_system_util.h"
 
 using content::BrowserContext;
 using content::BrowserThread;
 using content::ChildProcessSecurityPolicy;
 using content::SiteInstance;
 using content::WebContents;
 
@@ skipping 53 matching lines @@
         break;
       }
     }
   }
 
   return matching_patterns;
 }
 
 typedef std::set<const FileBrowserHandler*> ActionSet;
 
+std::string EscapedUtf8ToLower(const std::string& str) {
+  string16 utf16 = UTF8ToUTF16(
+      net::UnescapeURLComponent(str, net::UnescapeRule::NORMAL));

[SeRya, 2012/03/14 11:35:04]

Looks suspicious. You are unescaping whole URL with a method dedicated for
unescaping a component. Please, check that files like 'a#b.png' and 'a?b.png'
work file. We need to make sure this transformation doesn't move characters from
path to query or hash.

[Vladislav Kaznacheev, 2012/03/14 12:24:43]

Actually there is no net::UnescapeURL. The second parameter
(net::UnescapeRule::NORMAL) defines that none of the special symbols (%+&/#)
will be unescaped. This is why a#b works fine (I checked).

On 2012/03/14 11:35:04, SeRya wrote:

+  return net::EscapeUrlEncodedData(
+      UTF16ToUTF8(base::i18n::ToLower(utf16)),
+      false /* do not replace space with plus */);
+}
+
 bool GetFileBrowserHandlers(Profile* profile,
                             const GURL& selected_file_url,
                             ActionSet* results) {
   ExtensionService* service = profile->GetExtensionService();
   if (!service)
     return false;  // In unit-tests, we may not have an ExtensionService.
 
+  // We need case-insensitive matching, and pattern in the handler is already
+  // in lower case.
+  const GURL lowercase_url(EscapedUtf8ToLower(selected_file_url.spec()));
+  LOG(ERROR) << lowercase_url.spec();
+
   for (ExtensionSet::const_iterator iter = service->extensions()->begin();
        iter != service->extensions()->end();
        ++iter) {
     const Extension* extension = *iter;
     if (profile->IsOffTheRecord() &&
         !service->IsIncognitoEnabled(extension->id()))
       continue;
     if (!extension->file_browser_handlers())
       continue;
 
     for (Extension::FileBrowserHandlerList::const_iterator action_iter =
              extension->file_browser_handlers()->begin();
          action_iter != extension->file_browser_handlers()->end();
          ++action_iter) {
       const FileBrowserHandler* action = action_iter->get();
-      if (!action->MatchesURL(selected_file_url))
+      if (!action->MatchesURL(lowercase_url))
         continue;
 
       results->insert(action_iter->get());
     }
   }
   return true;
 }
 
 bool SortByLastUsedTimestampDesc(const LastUsedHandler& a,
                                  const LastUsedHandler& b) {
@@ skipping 407 matching lines @@
   base::JSONWriter::Write(event_args.get(), false, &json_args);
   event_router->DispatchEventToExtension(
       extension_id_, std::string("fileBrowserHandler.onExecute"),
       json_args, profile_,
       GURL());
   Done(true);
 }
 
 } // namespace file_handler_util