Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: media/base/pipeline_unittest.cc

Issue 9700006: Move VideoDecoder out of media pipeline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline.cc ('k') | media/filters/video_renderer_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index bb25dbade77870e44fdd1fbe43984975fbf80b9f..82e71546a8770084c556675fc6f7e2ed4a5aa421 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -131,12 +131,6 @@ class PipelineTest : public ::testing::Test {
EXPECT_CALL(*mocks_->video_decoder(),
Initialize(stream, _, _))
.WillOnce(WithArg<1>(Invoke(&RunPipelineStatusOKCB)));
- EXPECT_CALL(*mocks_->video_decoder(), SetPlaybackRate(0.0f));
- EXPECT_CALL(*mocks_->video_decoder(),
- Seek(mocks_->demuxer()->GetStartTime(), _))
- .WillOnce(Invoke(&RunPipelineStatusCB));
- EXPECT_CALL(*mocks_->video_decoder(), Stop(_))
- .WillOnce(Invoke(&RunStopFilterCallback));
}
// Sets up expectations to allow the audio decoder to initialize.
@@ -147,8 +141,8 @@ class PipelineTest : public ::testing::Test {
// Sets up expectations to allow the video renderer to initialize.
void InitializeVideoRenderer() {
- EXPECT_CALL(*mocks_->video_renderer(),
- Initialize(mocks_->video_decoder(), _, _, _))
+ EXPECT_CALL(*mocks_->video_renderer(), Initialize(
+ scoped_refptr<VideoDecoder>(mocks_->video_decoder()), _, _, _))
.WillOnce(Invoke(&RunPipelineStatusCB4));
EXPECT_CALL(*mocks_->video_renderer(), SetPlaybackRate(0.0f));
EXPECT_CALL(*mocks_->video_renderer(),
@@ -232,8 +226,6 @@ class PipelineTest : public ::testing::Test {
}
if (video_stream_) {
- EXPECT_CALL(*mocks_->video_decoder(), Seek(seek_time, _))
- .WillOnce(Invoke(&RunPipelineStatusCB));
EXPECT_CALL(*mocks_->video_renderer(), Seek(seek_time, _))
.WillOnce(Invoke(&RunPipelineStatusCB));
}
@@ -568,8 +560,6 @@ TEST_F(PipelineTest, DisableAudioRenderer) {
OnAudioRendererDisabled());
EXPECT_CALL(*mocks_->audio_renderer(),
OnAudioRendererDisabled());
- EXPECT_CALL(*mocks_->video_decoder(),
- OnAudioRendererDisabled());
EXPECT_CALL(*mocks_->video_renderer(),
OnAudioRendererDisabled());
@@ -600,8 +590,6 @@ TEST_F(PipelineTest, DisableAudioRendererDuringInit) {
OnAudioRendererDisabled());
EXPECT_CALL(*mocks_->audio_renderer(),
OnAudioRendererDisabled());
- EXPECT_CALL(*mocks_->video_decoder(),
- OnAudioRendererDisabled());
EXPECT_CALL(*mocks_->video_renderer(),
OnAudioRendererDisabled());
@@ -688,7 +676,6 @@ TEST_F(PipelineTest, AudioStreamShorterThanVideo) {
float playback_rate = 1.0f;
EXPECT_CALL(*mocks_->demuxer(), SetPlaybackRate(playback_rate));
- EXPECT_CALL(*mocks_->video_decoder(), SetPlaybackRate(playback_rate));
EXPECT_CALL(*mocks_->video_renderer(), SetPlaybackRate(playback_rate));
EXPECT_CALL(*mocks_->audio_renderer(), SetPlaybackRate(playback_rate));
pipeline_->SetPlaybackRate(playback_rate);
« no previous file with comments | « media/base/pipeline.cc ('k') | media/filters/video_renderer_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698