Implement more of allocation code using type arguments. Type argument extraction for non-factories …

runtime/vm/flow_graph_builder.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_BUILDER_H_
 #define VM_FLOW_GRAPH_BUILDER_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 99 matching lines @@
   // The original value is expected to be named with start_index-1, and the
   // result will be named with start_index.
   void BuildIncrOpIncrement(Token::Kind kind,
                             intptr_t node_id,
                             intptr_t token_index,
                             int start_index);
 
   void BuildTypeArguments(ConstructorCallNode* node,
                           ZoneGrowableArray<Value*>* args);
 
+  Value* GenerateInstantiatorTypeArguments(intptr_t token_index,

[regis, 2012/03/14 18:30:04]

GenerateInstantiatorTypeArguments and BuildTypeArguments above are missing
comments.

[srdjan, 2012/03/14 18:48:34]

Added comments.

  // Creates type arguments (one or two values in 'args') used in preparation
  // of a constructor or factory call.
  // For factory call instantiates and returns type argument vector in 'args'.
  // For constructor call returns type arguments and type arguments of the
  // instantiator.
  // May be called only if allocating an object of a parameterized class.
  void BuildTypeArguments(ConstructorCallNode* node,
                          ZoneGrowableArray<Value*>* args);

  // Returns the value of the type arguments of the instantiator.
  Value* GenerateInstantiatorTypeArguments(intptr_t token_index,
                                           intptr_t type_arguments);

+                                           intptr_t type_arguments);
+
   void CloseFragment() { exit_ = NULL; }
   intptr_t AllocateTempIndex() { return temp_index_++; }
 
  private:
   // Specify a computation as the final result.  Adds a Do instruction to
   // the graph, but normally overridden in subclasses.
   virtual void ReturnComputation(Computation* computation) {
     AddInstruction(new DoInstr(computation));
   }
 
@@ skipping 126 matching lines @@
   }
 
   // Output parameters.
   BlockEntryInstr** true_successor_address_;
   BlockEntryInstr** false_successor_address_;
 };
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_BUILDER_H_