Issue 9699110: Add more scripts for per-script font preferences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699110: Add more scripts for per-script font preferences. (Closed)

Created:
8 years, 9 months ago by falken

Modified:
8 years, 9 months ago

Reviewers:
jungshik at Google, Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more scripts for per-script font preferences. BUG=2685 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127436

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -10 lines)			Patch
M	chrome/common/extensions/api/experimental.fontSettings.json	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/fontSettings.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/fontSettings/popup.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/storage/stylizr.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.fontSettings.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

falken

jungshik: can you review these scripts? I chose them rather unscientifically, by comparing with Firefox ...

8 years, 9 months ago (2012-03-16 08:18:32 UTC) #1

jungshik at Google

8 years, 9 months ago (2012-03-26 20:27:32 UTC) #3

On 2012/03/16 21:34:06, Matt Perry wrote:
> lgtm

retroactive LGTM. The list you added is reasonable. We can add more later. 
Sorry for missing this and thank you for the change.

Expand Messages | Collapse Messages