Add functionality to pppapi TCPSocket to support secure sockets in flash

ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

Index: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
index 665ca73dfdd6e73cc4cd6faf3af53636871180ff..ca64f1d3a44750e800b0763b59671f69271e4072 100644
--- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
+++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
@@ -11,6 +11,18 @@
 
 namespace ppapi {
 
+PPB_X509Certificate_Fields::PPB_X509Certificate_Fields() {

[Ryan Sleevi, 2012/04/06 00:37:49]

nit: Same line for empty ctors when they fit.

[raymes, 2012/04/06 23:22:47]

Done.

+}
+
+PPB_X509Certificate_Fields::PPB_X509Certificate_Fields(
+    const PPB_X509Certificate_Fields& fields) {
+  for (size_t i = 0; i < fields.values_.GetSize(); ++i) {

[yzshen1, 2012/04/06 19:24:33]

[nit, optional] Can you use
virtual ListValue* DeepCopy() const OVERRIDE;
and then swap with values_?

[raymes, 2012/04/06 23:22:47]

Done.

+    base::Value* value;
+    fields.values_.Get(i, &value);
+    values_.Append(value->DeepCopy());
+  }
+}
+
 void PPB_X509Certificate_Fields::SetField(
     PP_X509Certificate_Private_Field field,
     base::Value* value) {
@@ -84,9 +96,10 @@ PPB_X509Certificate_Private_Shared::PPB_X509Certificate_Private_Shared(
 PPB_X509Certificate_Private_Shared::PPB_X509Certificate_Private_Shared(
     ResourceObjectType type,
     PP_Instance instance,
-    PPB_X509Certificate_Fields* fields)
-    : Resource(type, instance),
-      fields_(fields) {
+    const PPB_X509Certificate_Fields& fields)
+        : Resource(type, instance),

[yzshen1, 2012/04/06 19:24:33]

I think the convention is to *not* add 4 more spaces in this case.

[raymes, 2012/04/06 23:22:47]

Done.

+          fields_(new PPB_X509Certificate_Fields(fields))
+    {

[yzshen1, 2012/04/06 19:24:33]

And move it to the end of the previous line.

[raymes, 2012/04/06 23:22:47]

Done.

 }
 
 PPB_X509Certificate_Private_Shared::~PPB_X509Certificate_Private_Shared() {