Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: net/base/x509_certificate_mac.cc

Issue 9699058: When detecting client certs on OS X, ensure all certs match the server's CertificateRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Whitespace Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_mac.cc
diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc
index 1f8103f08be21aaf14ee51741fcf99c4388c0e3c..9103152ec85445f6c615b9ba374938cde94af03f 100644
--- a/net/base/x509_certificate_mac.cc
+++ b/net/base/x509_certificate_mac.cc
@@ -1493,10 +1493,7 @@ bool X509Certificate::GetSSLClientCertificates(
CFEqual(preferred_identity, identity);
// Make sure the issuer matches valid_issuers, if given.
- // But an explicit cert preference overrides this.
- if (!is_preferred &&
- !valid_issuers.empty() &&
- !cert->IsIssuedBy(valid_issuers))
+ if (!valid_issuers.empty() && !cert->IsIssuedBy(valid_issuers))
continue;
// The cert passes, so add it to the vector.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698