When detecting client certs on OS X, ensure all certs match the server's CertificateRequest

When detecting client certs on OS X, ensure all certs match the server's CertificateRequest

Previously, if an identity preference for a server existed,
such as those created by Safari, then the client certificate
would not be checked to ensure it matched the server's
CertificateRequest. As a result, it was possible to send a
potentially invalid client certificate - and this would
be the default client certificate presented to users.

BUG=118306
TEST=See bug
R=wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126836

[Ryan Sleevi, 2012-03-15 00:51:22]

As discussed.

[wtc, 2012-03-15 01:44:53]

LGTM.  This is a good change!

http://codereview.chromium.org/9699058/diff/1/net/base/x509_certificate_mac.cc
File net/base/x509_certificate_mac.cc (right):

http://codereview.chromium.org/9699058/diff/1/net/base/x509_certificate_mac.c...
net/base/x509_certificate_mac.cc:1497: !cert->IsIssuedBy(valid_issuers))

Nit: this conditional expression should fit in one line now.

[commit-bot: I haz the power, 2012-03-15 01:48:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9699058/4001

[commit-bot: I haz the power, 2012-03-15 04:10:42]

Try job failure for 9699058-4001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...