Chromium Code Reviews Chromium Code Reviews
Issue
9699054:
rlz: Hook up on mac, switch to chrome's network stack on win. (Closed)
Descriptionrlz: Hook up on mac, switch to chrome's network stack on win.
This CL conceptually does several things (most of them just one line).
1. Roll RLZ 105:118
106: Fix "expression result unused" warning caused by VERIFY() use.
107: rlz: Add an implementation of PingServer() that uses chrome's net stack.
108: Implement RlzValueStoreMac.
109: Move GetMachineId() to its own file. No intended behavior change.
110: Implement GetSystemTimeAsInt64() on mac.
111: Minor cleanups.
112: Don't pay a static initializer for expected_assertion_ when it's not used.
113: Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc
114: mac: Implement GetMachineId().
115: mac: Implement the locking part of ScopedRlzValueStoreLock.
116: Tweaks to make the use of chrome's net stack forceable through gyp.
117: Push RLZ_NETWORK_IMPLEMENTATION_ define to dependent targets.
118: Use base::mac::ScopedNSAutorleasePool only on mac.
2. Change rlz.cpp to use the blocking pool instead of the file thread.
3. Enable on mac.
4. Switch to chrome's network stack on windows
5. Switch RlzSendFinancialPingFunction to be an AsyncExtensionFunction
that calls SendFinancialPing on a worker thread. This is required because
extension functions run with a MessageLoop, so the MessageLoop in
SendFinancialPing in rlz would trigger an assert (and making that inner
loop nestable seems like a very bad idea). This change also removes
one instance of ScopedAllowIO and fixes a TODO.
BUG=46579
TEST=
1.) Do an official chrome build
2.) Add gratuitous logging in rlz.cc and other places and check that by default:
* The channel is reported as "stable"
* The brand code is the empty string
* This brand code counts as organic install
* RLZ exits early.
3.) Create ~/Library/Google/Google\ Chrome\ Brand.plist and add e.g. the string "BRAND" for key KSBrandID, restart chrome.
* Brand code is now "BRAND" (this depends on Chrome's Info.plist not having a KSBrandID key, which has precedence. Currently our Chromes seem to never have this key.)
* A ping is scheduled, but nothing is sent.
* Use the omnibox a little, which causes product events to be recorded.
4.) Restart chrome yet again, wait a bit.
* Logging in "SendFinancialPing()" should print:
pinging http://clients1.google.com:80/tools/pso/ping?as=chrome&brand=BRAND&pid=&hl=en&events=C1F,C1S&rep=2&rlz=C1:1C1_____enUS476,C2:1C2_____enUS476&id=0926C138C2EA77A791CB450D322D0183E5A8079300000001B5
ping completed!
TBR=sky
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129028
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : rebase #Patch Set 5 : rebase #Patch Set 6 : foo #Patch Set 7 : blocking pool #Patch Set 8 : . #Patch Set 9 : . #Patch Set 10 : . #Patch Set 11 : . #Patch Set 12 : oops #Patch Set 13 : . #
Total comments: 6
Patch Set 14 : comments #Patch Set 15 : search terms & test #Patch Set 16 : 116 #Patch Set 17 : one more place #Patch Set 18 : compile in (but do not use) rlz extension apis for non-branded builds #Patch Set 19 : . #Patch Set 20 : 117 #Patch Set 21 : 118 #Patch Set 22 : Forgot to enable a few tests on mac #Patch Set 23 : extension on worker pool #Patch Set 24 : . #Patch Set 25 : last test should pass #
Total comments: 16
Patch Set 26 : comments #Patch Set 27 : different thread #Patch Set 28 : rebase #
Total comments: 2
Messages
Total messages: 17 (0 generated)
|
