Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.h

Issue 9699045: [Mac] Make ExtensionPopupController is-a BaseBubbleController to unify code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
index 02ac2da2ecf32dfdf18b09107a9b5948c70e68e2..6909df5c8a8be11dd3787762bb6cc9a5b030890c 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
@@ -11,7 +11,8 @@
#import "base/mac/cocoa_protocols.h"
#import "base/memory/scoped_nsobject.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/browser/ui/cocoa/info_bubble_view.h"
+#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
+#import "chrome/browser/ui/cocoa/info_bubble_view.h"
#include "googleurl/src/gurl.h"
@@ -19,7 +20,6 @@ class Browser;
class DevtoolsNotificationBridge;
class ExtensionHost;
class ExtensionPopupContainer;
-@class InfoBubbleWindow;
namespace content {
class NotificationRegistrar;
@@ -32,18 +32,11 @@ class NotificationRegistrar;
//
// There can only be one browser action popup open at a time, so a static
// variable holds a reference to the current popup.
-@interface ExtensionPopupController : NSWindowController<NSWindowDelegate> {
+@interface ExtensionPopupController : BaseBubbleController {
@private
// The native extension view retrieved from the extension host. Weak.
NSView* extensionView_;
- // The popup's parent window. Weak.
- NSWindow* parentWindow_;
-
- // Where the window is anchored. Right now it's the bottom center of the
- // browser action button.
- NSPoint anchor_;
-
// The current frame of the extension view. Cached to prevent setting the
// frame if the size hasn't changed.
NSRect extensionFrame_;
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698