Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: net/base/crl_set_unittest.cc

Issue 9699043: net: fallback to online revocation checks for EV status when CRLSet has expired. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/crl_set_unittest.cc
diff --git a/net/base/crl_set_unittest.cc b/net/base/crl_set_unittest.cc
index d1265b7c83bbef49e25dc5852e6b3fd35171b22b..42fa82abff2c87d422c6cd1a0f1d8d63aaa77470 100644
--- a/net/base/crl_set_unittest.cc
+++ b/net/base/crl_set_unittest.cc
@@ -208,6 +208,8 @@ TEST(CRLSetTest, Parse) {
EXPECT_EQ(net::CRLSet::GOOD, set->CheckSerial(
std::string("\x47\x54\x3E\x79\x00\x03\x00\x00\x14\xF5", 10),
gia_spki_hash));
+
+ EXPECT_FALSE(set->IsExpired());
}
TEST(CRLSetTest, NoOpDeltaUpdate) {
@@ -311,7 +313,7 @@ TEST(CRLSetTest, BlockedSPKIs) {
reinterpret_cast<const char*>(spki_hash)));
}
-TEST(CRLSetTest, Expires) {
+TEST(CRLSetTest, Expired) {
// This CRLSet has an expiry value set to one second past midnight, 1st Jan,
// 1970.
base::StringPiece s(reinterpret_cast<const char*>(kExpiredCRLSet),
@@ -320,6 +322,5 @@ TEST(CRLSetTest, Expires) {
EXPECT_TRUE(net::CRLSet::Parse(s, &set));
ASSERT_TRUE(set.get() != NULL);
- EXPECT_EQ(net::CRLSet::CRL_SET_EXPIRED, set->CheckSerial(
- std::string("\x01", 1), ""));
+ EXPECT_TRUE(set->IsExpired());
}

Powered by Google App Engine
This is Rietveld 408576698