net: fallback to online revocation checks for EV status when CRLSet has expired.

net/base/crl_set_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/crl_set.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // These data blocks were generated using a lot of code that is still in
 // development. For now, if you need to update them, you have to contact agl.
 static const uint8 kGIACRLSet[] = {
@@ skipping 190 matching lines @@
 
   const std::string gia_spki_hash(
       reinterpret_cast<const char*>(kGIASPKISHA256),
       sizeof(kGIASPKISHA256));
   EXPECT_EQ(net::CRLSet::REVOKED, set->CheckSerial(
       std::string("\x16\x7D\x75\x9D\x00\x03\x00\x00\x14\x55", 10),
       gia_spki_hash));
   EXPECT_EQ(net::CRLSet::GOOD, set->CheckSerial(
       std::string("\x47\x54\x3E\x79\x00\x03\x00\x00\x14\xF5", 10),
       gia_spki_hash));
+
+  EXPECT_FALSE(set->IsExpired());
 }
 
 TEST(CRLSetTest, NoOpDeltaUpdate) {
   base::StringPiece s(reinterpret_cast<const char*>(kGIACRLSet),
                       sizeof(kGIACRLSet));
   scoped_refptr<net::CRLSet> set;
   EXPECT_TRUE(net::CRLSet::Parse(s, &set));
   ASSERT_TRUE(set.get() != NULL);
 
   scoped_refptr<net::CRLSet> delta_set;
@@ skipping 83 matching lines @@
     227, 176, 196, 66, 152, 252, 28, 20, 154, 251, 244, 200, 153, 111, 185, 36,
     39, 174, 65, 228, 100, 155, 147, 76, 164, 149, 153, 27, 120, 82, 184, 85,
     0,
   };
 
   EXPECT_EQ(net::CRLSet::GOOD, set->CheckSPKI(""));
   EXPECT_EQ(net::CRLSet::REVOKED, set->CheckSPKI(
       reinterpret_cast<const char*>(spki_hash)));
 }
 
-TEST(CRLSetTest, Expires) {
+TEST(CRLSetTest, Expired) {
   // This CRLSet has an expiry value set to one second past midnight, 1st Jan,
   // 1970.
   base::StringPiece s(reinterpret_cast<const char*>(kExpiredCRLSet),
                       sizeof(kExpiredCRLSet));
   scoped_refptr<net::CRLSet> set;
   EXPECT_TRUE(net::CRLSet::Parse(s, &set));
   ASSERT_TRUE(set.get() != NULL);
 
-  EXPECT_EQ(net::CRLSet::CRL_SET_EXPIRED, set->CheckSerial(
-      std::string("\x01", 1), ""));
+  EXPECT_TRUE(set->IsExpired());
 }