Issue 9699029: Remove use_skia_on_mac.gypi ; building with CG is no longer supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699029: Remove use_skia_on_mac.gypi ; building with CG is no longer supported. (Closed)

Created:
8 years, 9 months ago by epoger

Modified:
8 years, 9 months ago

Reviewers:
_cary, caryclark

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove use_skia_on_mac.gypi ; building with CG is no longer supported. BUG=110881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126652

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -20 lines)			Patch
	M	build/common.gypi	View		6 chunks	+1 line, -11 lines	2 comments	Download
	D	build/use_skia_on_mac.gypi	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

_cary

lgtm https://chromiumcodereview.appspot.com/9699029/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/9699029/diff/1/build/common.gypi#newcode297 build/common.gypi:297: 'use_skia%': 1, Does the TODO above mean also ...

8 years, 9 months ago (2012-03-14 15:59:25 UTC) #2

epoger

8 years, 9 months ago (2012-03-14 16:01:35 UTC) #3

https://chromiumcodereview.appspot.com/9699029/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9699029/diff/1/build/common.gypi#newco...
build/common.gypi:297: 'use_skia%': 1,
On 2012/03/14 15:59:25, _cary wrote:
> Does the TODO above mean also that use_skia can't be moved outside of the
> OS=='mac' clause?

Yup, for now at least.  My intent is to kill use_skia_on_mac first of all, and
then kill use_skia entirely in a separate CL.

Expand Messages | Collapse Messages