Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 9699014: Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles() (Closed)

Created:
8 years, 9 months ago by tkent
Modified:
8 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles() https://bugs.webkit.org/show_bug.cgi?id=80648 Reviewed by Simon Fraser. Source/WebCore: Test: fast/events/input-element-display-none-in-dragleave-crash.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer(). LayoutTests: * fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added. * fast/events/input-element-display-none-in-dragleave-crash.html: Added. * platform/wk2/Skipped: WebKitTestRunner doesn't support EventSender.beginDragWithFiles(). TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=110670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
A + LayoutTests/fast/events/input-element-display-none-in-dragleave-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/input-element-display-none-in-dragleave-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
8 years, 9 months ago (2012-03-14 07:31:20 UTC) #1
tkent
8 years, 9 months ago (2012-03-14 07:33:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698