Issue 9699014: Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699014: Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles() (Closed)

Created:
8 years, 9 months ago by tkent

Modified:
8 years, 9 months ago

Reviewers:
tkent

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/

Visibility:
Public.

More Reviews

Description

Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles() https://bugs.webkit.org/show_bug.cgi?id=80648 Reviewed by Simon Fraser. Source/WebCore: Test: fast/events/input-element-display-none-in-dragleave-crash.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer(). LayoutTests: * fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added. * fast/events/input-element-display-none-in-dragleave-crash.html: Added. * platform/wk2/Skipped: WebKitTestRunner doesn't support EventSender.beginDragWithFiles(). TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=110670

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, --1 lines)			Patch
A +	LayoutTests/fast/events/input-element-display-none-in-dragleave-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/events/input-element-display-none-in-dragleave-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/html/HTMLInputElement.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages