Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9699013: MonitorManager to manage multiple monitors. (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

MonitorManager to manage multiple monitors. This is clone of issue 9689027, which I can't access due to some internal error. BUG=115510 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126685

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -71 lines) Patch
M ash/screen_ash.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ash/screen_ash.cc View 3 chunks +17 lines, -18 lines 0 comments Download
M ash/shell.h View 1 chunk +4 lines, -2 lines 1 comment Download
M ash/shell.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M ash/shell_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 5 chunks +17 lines, -8 lines 2 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/env.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 3 chunks +10 lines, -1 line 0 comments Download
A ui/aura/monitor.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ui/aura/monitor.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager.cc View 1 1 chunk +86 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager_x11.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
Ben, can you approve this? This is basically same as 9689027, but modified to merge ...
8 years, 9 months ago (2012-03-14 16:31:30 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/9699013/diff/4002/ash/wm/shelf_layout_manager_unittest.cc File ash/wm/shelf_layout_manager_unittest.cc (right): http://codereview.chromium.org/9699013/diff/4002/ash/wm/shelf_layout_manager_unittest.cc#newcode110 ash/wm/shelf_layout_manager_unittest.cc:110: manager->GetMonitorNearestWindow(Shell::GetRootWindow()); I suspect we'll want some convenience function that ...
8 years, 9 months ago (2012-03-14 17:01:26 UTC) #2
oshima
http://codereview.chromium.org/9699013/diff/4002/ash/wm/shelf_layout_manager_unittest.cc File ash/wm/shelf_layout_manager_unittest.cc (right): http://codereview.chromium.org/9699013/diff/4002/ash/wm/shelf_layout_manager_unittest.cc#newcode110 ash/wm/shelf_layout_manager_unittest.cc:110: manager->GetMonitorNearestWindow(Shell::GetRootWindow()); On 2012/03/14 17:01:26, Ben Goodger (Google) wrote: > ...
8 years, 9 months ago (2012-03-14 17:19:43 UTC) #3
Ben Goodger (Google)
8 years, 9 months ago (2012-03-14 17:23:16 UTC) #4
SG. LGTM for this

Powered by Google App Engine
This is Rietveld 408576698