Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9699002: Uber: Allow dialogs to be smaller than 90%. (Closed)

Created:
8 years, 9 months ago by James Hawkins
Modified:
8 years, 9 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Uber: Allow dialogs to be smaller than 90%. Now we just update the max-height to min(90%, 640px), which is not currently possible in CSS. BUG=118031 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126510

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove padding-bottom. #

Patch Set 3 : Logic change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M chrome/browser/resources/shared/css/overlay.css View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/overlay.js View 1 2 5 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
8 years, 9 months ago (2012-03-13 23:03:35 UTC) #1
csilv
https://chromiumcodereview.appspot.com/9699002/diff/1/chrome/browser/resources/shared/css/overlay.css File chrome/browser/resources/shared/css/overlay.css (right): https://chromiumcodereview.appspot.com/9699002/diff/1/chrome/browser/resources/shared/css/overlay.css#newcode17 chrome/browser/resources/shared/css/overlay.css:17: padding-bottom: 130px; let's get rid of badding-bottom. https://chromiumcodereview.appspot.com/9699002/diff/1/chrome/browser/resources/shared/js/cr/ui/overlay.js File ...
8 years, 9 months ago (2012-03-13 23:28:04 UTC) #2
James Hawkins
https://chromiumcodereview.appspot.com/9699002/diff/1/chrome/browser/resources/shared/css/overlay.css File chrome/browser/resources/shared/css/overlay.css (right): https://chromiumcodereview.appspot.com/9699002/diff/1/chrome/browser/resources/shared/css/overlay.css#newcode17 chrome/browser/resources/shared/css/overlay.css:17: padding-bottom: 130px; On 2012/03/13 23:28:04, csilv wrote: > let's ...
8 years, 9 months ago (2012-03-13 23:39:14 UTC) #3
csilv
lgtm
8 years, 9 months ago (2012-03-13 23:48:48 UTC) #4
csilv
8 years, 9 months ago (2012-03-13 23:52:35 UTC) #5
lgtm

slgtm.

Powered by Google App Engine
This is Rietveld 408576698