Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 9697001: Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload https://bugs.webkit.org/show_bug.cgi?id=79841 Patch by Dana Jansens <danakj@chromium.org>; on 2012-02-29 Reviewed by James Robinson. Source/WebCore: We currently don't push dirty tiles to the impl thread so there are no tiles with garbage data on the impl thread. However, this judgement is overzealous and blocks tiles that get invalidated by WebKit for the next frame during the paint of the current frame. Instead, check if a tile is dirty and was not painted for the current frame when deciding to push the tile to the impl thread. This requires that we know if a tile was painted during the current frame, which we can do if we always reset m_updateRect to be empty each frame. New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::UpdatableTile::isDirtyForCurrentFrame): (WebCore::TiledLayerChromium::pushPropertiesTo): (WebCore::TiledLayerChromium::prepareToUpdateTiles): (WebCore::TiledLayerChromium::resetUpdateState): (WebCore): (WebCore::TiledLayerChromium::prepareToUpdate): * platform/graphics/chromium/TiledLayerChromium.h: (TiledLayerChromium): Source/WebKit/chromium: * tests/TiledLayerChromiumTest.cpp: (WTF::TEST): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=110467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3967 lines, -7 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +1667 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp View 5 chunks +14 lines, -7 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +2187 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 9 months ago (2012-03-12 19:06:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698