Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9696051: Add NetworkListObserver utility class. (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add NetworkListObserver utility class. BUG=114808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128015

Patch Set 1 #

Total comments: 8

Patch Set 2 : - #

Total comments: 6

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -24 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/cpp/private/network_list_private.h View 2 chunks +8 lines, -7 lines 0 comments Download
M ppapi/cpp/private/network_list_private.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/tests/test_network_monitor_private.h View 2 chunks +7 lines, -1 line 0 comments Download
M ppapi/tests/test_network_monitor_private.cc View 1 2 3 8 chunks +43 lines, -9 lines 0 comments Download
A ppapi/utility/private/DEPS View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A ppapi/utility/private/network_list_observer_private.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A ppapi/utility/private/network_list_observer_private.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sergey Ulanov
8 years, 9 months ago (2012-03-14 20:37:26 UTC) #1
dmichael (off chromium)
http://codereview.chromium.org/9696051/diff/1/ppapi/utility/network_list_observer.h File ppapi/utility/network_list_observer.h (right): http://codereview.chromium.org/9696051/diff/1/ppapi/utility/network_list_observer.h#newcode6 ppapi/utility/network_list_observer.h:6: #define PPAPI_UTILITY_NETWORK_LIST_OBSERVER_H_ It should probably go in a ppapi/utility/private ...
8 years, 9 months ago (2012-03-15 20:16:58 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9696051/diff/1/ppapi/utility/network_list_observer.h File ppapi/utility/network_list_observer.h (right): http://codereview.chromium.org/9696051/diff/1/ppapi/utility/network_list_observer.h#newcode6 ppapi/utility/network_list_observer.h:6: #define PPAPI_UTILITY_NETWORK_LIST_OBSERVER_H_ On 2012/03/15 20:16:58, dmichael wrote: > It ...
8 years, 9 months ago (2012-03-15 23:44:08 UTC) #3
dmichael (off chromium)
http://codereview.chromium.org/9696051/diff/4001/ppapi/utility/private/network_list_observer.cc File ppapi/utility/private/network_list_observer.cc (right): http://codereview.chromium.org/9696051/diff/4001/ppapi/utility/private/network_list_observer.cc#newcode14 ppapi/utility/private/network_list_observer.cc:14: this) { You probably need to use PP_ALLOW_THIS_IN_INITIALIZER_LIST to ...
8 years, 9 months ago (2012-03-16 20:06:11 UTC) #4
Sergey Ulanov
http://codereview.chromium.org/9696051/diff/4001/ppapi/utility/private/network_list_observer.cc File ppapi/utility/private/network_list_observer.cc (right): http://codereview.chromium.org/9696051/diff/4001/ppapi/utility/private/network_list_observer.cc#newcode14 ppapi/utility/private/network_list_observer.cc:14: this) { On 2012/03/16 20:06:11, dmichael wrote: > You ...
8 years, 9 months ago (2012-03-17 00:43:48 UTC) #5
dmichael (off chromium)
lgtm http://codereview.chromium.org/9696051/diff/7004/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/9696051/diff/7004/chrome/test/ui/ppapi_uitest.cc#newcode278 chrome/test/ui/ppapi_uitest.cc:278: nit: extra line http://codereview.chromium.org/9696051/diff/7004/ppapi/tests/test_network_monitor_private.cc File ppapi/tests/test_network_monitor_private.cc (right): http://codereview.chromium.org/9696051/diff/7004/ppapi/tests/test_network_monitor_private.cc#newcode60 ...
8 years, 9 months ago (2012-03-19 16:30:31 UTC) #6
Sergey Ulanov
http://codereview.chromium.org/9696051/diff/7004/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/9696051/diff/7004/chrome/test/ui/ppapi_uitest.cc#newcode278 chrome/test/ui/ppapi_uitest.cc:278: On 2012/03/19 16:30:32, dmichael wrote: > nit: extra line ...
8 years, 9 months ago (2012-03-20 20:21:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9696051/14001
8 years, 9 months ago (2012-03-20 20:25:51 UTC) #8
commit-bot: I haz the power
Change committed as 127797
8 years, 9 months ago (2012-03-20 21:39:44 UTC) #9
Sergey Ulanov
Dave, this change was failing check_deps when checked in (not sure why trybots didn't catch ...
8 years, 9 months ago (2012-03-21 00:01:13 UTC) #10
dmichael (off chromium)
lgtm
8 years, 9 months ago (2012-03-21 17:31:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9696051/28020
8 years, 9 months ago (2012-03-21 17:34:30 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 18:22:09 UTC) #13 
Try job failure for 9696051-28020 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698