Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: runtime/lib/date.cc

Issue 9696048: Address Ivan's review comments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/lib/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "vm/bigint_operations.h" 7 #include "vm/bigint_operations.h"
8 #include "vm/exceptions.h"
9 #include "vm/native_entry.h" 8 #include "vm/native_entry.h"
10 #include "vm/object.h" 9 #include "vm/object.h"
11 #include "vm/os.h" 10 #include "vm/os.h"
12 11
13 namespace dart { 12 namespace dart {
14 13
15 static bool BreakDownSecondsSinceEpoch(const Integer& dart_seconds, 14 static bool BreakDownSecondsSinceEpoch(const Integer& dart_seconds,
16 const Bool& dart_is_utc, 15 const Bool& dart_is_utc,
17 OS::BrokenDownDate* result) { 16 OS::BrokenDownDate* result) {
18 bool is_utc = dart_is_utc.value(); 17 bool is_utc = dart_is_utc.value();
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 bool succeeded = 146 bool succeeded =
148 BreakDownSecondsSinceEpoch(dart_seconds, dart_is_utc, &broken_down); 147 BreakDownSecondsSinceEpoch(dart_seconds, dart_is_utc, &broken_down);
149 if (!succeeded) { 148 if (!succeeded) {
150 UNIMPLEMENTED(); 149 UNIMPLEMENTED();
151 } 150 }
152 const Smi& result = Smi::Handle(Smi::New(broken_down.seconds)); 151 const Smi& result = Smi::Handle(Smi::New(broken_down.seconds));
153 arguments->SetReturn(result); 152 arguments->SetReturn(result);
154 } 153 }
155 154
156 } // namespace dart 155 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698