Expose a spdy session's pooled aliases in the net-internals page.

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 1114 matching lines @@
     CloseAllStreams(err);
   }
 }
 
 Value* SpdySession::GetInfoAsValue() const {
   DictionaryValue* dict = new DictionaryValue();
 
   dict->SetInteger("source_id", net_log_.source().id);
 
   dict->SetString("host_port_pair", host_port_proxy_pair_.first.ToString());
+  ListValue* alias_list = new ListValue();
+  for (std::set<HostPortProxyPair>::const_iterator it = pooled_aliases_.begin();
+       it != pooled_aliases_.end(); it++) {
+    alias_list->Append(Value::CreateStringValue(it->first.ToString()));
+  }
+  dict->Set("aliases", alias_list);

[eroman, 2012/03/13 20:08:42]

I suggest only setting the aliases property if there are any aliases.

[Ryan Hamilton, 2012/03/13 21:55:37]

Done.  (I had thought we would prefer the property to always be there in .js
land.  Not sure why I thought this).

   dict->SetString("proxy", host_port_proxy_pair_.second.ToURI());
 
   dict->SetInteger("active_streams", active_streams_.size());
 
   dict->SetInteger("unclaimed_pushed_streams",
       unclaimed_pushed_streams_.size());
 
   dict->SetBoolean("is_secure", is_secure_);
 
   SSLClientSocket::NextProto proto = SSLClientSocket::kProtoUnknown;
@@ skipping 800 matching lines @@
 SSLClientSocket* SpdySession::GetSSLClientSocket() const {
   if (!is_secure_)
     return NULL;
   SSLClientSocket* ssl_socket =
       reinterpret_cast<SSLClientSocket*>(connection_->socket());
   DCHECK(ssl_socket);
   return ssl_socket;
 }
 
 }  // namespace net