Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 9696028: Get rid of |get x(x)| pattern in tracing/ (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
nduca
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Get rid of |get x(x)| pattern in tracing/ BUG=117626 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/tracing/timeline_track.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tyler Breisacher (Chromium)
See http://code.google.com/p/chromium/issues/detail?id=117626 and http://code.google.com/p/v8/issues/detail?id=1998
8 years, 9 months ago (2012-03-13 04:25:04 UTC) #1
nduca
lgtm Thanks!
8 years, 9 months ago (2012-03-13 04:40:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9696028/1
8 years, 9 months ago (2012-03-13 04:41:09 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 06:51:05 UTC) #4
Try job failure for 9696028-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698