Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 9696025: Rename InputMethodManager::current_input_method() to InputMethodManager::GetCurrentInputMethod(). (Closed)

Created:
8 years, 9 months ago by Yusuke Sato
Modified:
8 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

- Rename InputMethodManager::current_input_method() to InputMethodManager::GetCurrentInputMethod() since it's not a simple getter. - Do the same for previous_input_method() and current_ime_properties(). - Rename 'struct ImeProperty' to 'struct InputMethodProperty' to avoid abbreviations. This is for crosbug.com/19655. BUG=chromium-os:19655 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126812

Patch Set 1 : review #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -108 lines) Patch
M chrome/browser/chromeos/extensions/input_method_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.h View 1 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.cc View 1 10 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_ui_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 10 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc View 1 chunk +32 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 10 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_method_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuke Sato
8 years, 9 months ago (2012-03-13 04:14:21 UTC) #1
mazda
lgtm
8 years, 9 months ago (2012-03-13 04:27:15 UTC) #2
Yusuke Sato
+mpcomplete (chrome/browser/extensions/), +stevenjb (chrome/browser/chromeos/status/), +nkostylev (chrome/browser/chromeos/login/ and chrome/browser/ui/webui/chromeos/). Could you do OWNERS review?
8 years, 9 months ago (2012-03-13 04:38:26 UTC) #3
Nikita (slow)
chrome/browser/chromeos/login/ chrome/browser/ui/webui/chromeos/ lgtm
8 years, 9 months ago (2012-03-13 08:06:22 UTC) #4
Matt Perry
lgtm
8 years, 9 months ago (2012-03-13 20:42:06 UTC) #5
Yusuke Sato
Steven, could you review this too?
8 years, 9 months ago (2012-03-14 22:57:41 UTC) #6
stevenjb
8 years, 9 months ago (2012-03-14 23:28:01 UTC) #7
owner lgtm for status area.

Powered by Google App Engine
This is Rietveld 408576698