Issue 9695064: Simplify GetTranslatedNexe()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9695064: Simplify GetTranslatedNexe() (Closed)

Created:
8 years, 9 months ago by Mark Seaborn

Modified:
8 years, 9 months ago

Reviewers:
(google.com) Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Scons: Simplify GetTranslatedNexe() Use Scons's automatic dependency tracking. Remove unused "trans_flags" variable. This addresses some review comments from https://chromiumcodereview.appspot.com/9696046/. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2609 TEST=small_tests bitcode=1 pnacl_stop_with_pexe=1 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8031

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -29 lines)			Patch
M	SConstruct	View	1	3 chunks	+7 lines, -16 lines	0 comments	Download
M	site_scons/site_tools/naclsdk.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/minnacl/nacl.scons	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/multiple_sandboxes/nacl.scons	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

The change in https://chromiumcodereview.appspot.com/9696046/ seemed more complicated than necessary. This simplifies it.

8 years, 9 months ago (2012-03-13 22:13:16 UTC) #1

(google.com) Derek Schuff

LGTM, thanks. On 2012/03/13 22:13:16, Mark Seaborn wrote: > The change in https://chromiumcodereview.appspot.com/9696046/ seemed more ...

8 years, 9 months ago (2012-03-13 22:16:58 UTC) #2

Mark Seaborn

8 years, 9 months ago (2012-03-14 23:51:57 UTC) #3

On 13 March 2012 15:16, <dschuff@google.com> wrote:

> LGTM, thanks.
>

Committed, thanks!

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Expand Messages | Collapse Messages