Issue 9695062: NaCl: Switch to using the new extensible startup interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9695062: NaCl: Switch to using the new extensible startup interface (Closed)

Created:
8 years, 9 months ago by Mark Seaborn

Modified:
8 years, 9 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com, bradn

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Switch to using the new extensible startup interface The new interface is C-based so the CreateMemoryObject() callback now takes an int rather than a bool. I have opted to wrap content::MakeSharedMemorySegmentViaIPC() rather than change the types in the "content" tree: arguably NaCl's use of a C interface here should not spill over too far into Chromium's C++ code. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2651 TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126855

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -19 lines)			Patch
	M	chrome/nacl/nacl_listener.cc	View		6 chunks	+26 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 9 months ago (2012-03-15 06:03:21 UTC) #3

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages