Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 9695058: Don't enforce the old HMAC key size requirement in FIPS 198 Sec. 3. (Closed)

Created:
8 years, 9 months ago by wtc
Modified:
8 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, Nick Bray (chromium)
Visibility:
Public.

Description

Don't enforce the old HMAC key size requirement in FIPS 198 Sec. 3. This requirement has been removed in FIPS 198-1. R=rsleevi@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M crypto/hmac.h View 1 chunk +8 lines, -0 lines 0 comments Download
M crypto/hmac_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
Sad to see the stronger check go, but LGTM. FWIW, the wording was changed because ...
8 years, 9 months ago (2012-03-13 19:50:25 UTC) #1
wtc
rsleevi: please doublecheck I read FIPS 198-1 Section 3 and NIST SP 800-107 Sections 5.3.2 ...
8 years, 9 months ago (2012-03-13 19:51:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/9695058/1
8 years, 9 months ago (2012-03-14 01:39:18 UTC) #3
commit-bot: I haz the power
Try job failure for 9695058-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-14 04:06:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/9695058/1
8 years, 9 months ago (2012-03-14 14:59:33 UTC) #5
commit-bot: I haz the power
Try job failure for 9695058-1 (retry) on linux_rel for step "remoting_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-14 15:50:55 UTC) #6
wtc
8 years, 9 months ago (2012-03-14 17:58:34 UTC) #7
On 2012/03/13 19:50:25, Ryan Sleevi wrote:
> Sad to see the stronger check go, but LGTM.
> 
> FWIW, the wording was changed because of the SHA-2/SHA-3 suites, where less
than
> half was still "good enough". SHA-1's minimum is still 'at least' half
(although
> with recent attacks, I seem to recall it's even greater).

Thank you for the comment.

FIPS 198 was indeed issued earlier than SHA-2 (FIPS 180-2), though
by only a few months (March vs. August of 2002).  It is strange that
FIPS 198 didn't take into account the imminent SHA-2 algorithms.

It's also strange that SP 800-107 compares the key size (or rather,
the key's security strength) with 2L instead of L/2.  (It is a
different kind of comparison though.)  If we follow the recommendation
of SP 800-107, there is no need to use HMAC with SHA-256 at the
128-bit security level.

Powered by Google App Engine
This is Rietveld 408576698