Issue 9695040: Convert CRLF to LF in json_string_value_serializer.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9695040: Convert CRLF to LF in json_string_value_serializer.cc (Closed)

Created:
8 years, 9 months ago by Eric Dingle

Modified:
8 years, 9 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert CRLF to LF in json_string_value_serializer.cc BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126418

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -45 lines)			Patch
	M	base/json/json_string_value_serializer.cc	View		1 chunk	+45 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9695040/1

8 years, 9 months ago (2012-03-13 17:37:38 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-13 17:37:39 UTC) #4

Can't apply patch for file base/json/json_string_value_serializer.cc.
While running patch -p1 --forward --force;
patching file base/json/json_string_value_serializer.cc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
base/json/json_string_value_serializer.cc.rej

Expand Messages | Collapse Messages